-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix missing changelog entries #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a more human-centric changelog format that focuses on the important parts for the dependants' maintainers. Please check it out in the internal wiki.
I feel that this should be part of separate issue if we want to modify the format of the changelog:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I concur that this is addressing a fix in the current and changing the documented cookbook workflow is a separate policy change.
I agree in which case a cookbook version bump should not happen as part of this PR. |
I removed the version change from this PR and will bump as part of a release commit after testing the fixes for change log generation. |
Changelog updates from github-changelog-generator have been overwriting the existing version since v3.3.0 due to missing tags in the release process.
Tasks
git tag <tag-name> <commit-sha>
git push origin <tag-name>